Help debugging simple .bat that worked on XP

Ok. You need to change the following lines in the above code:

Windows 7 compliant

Code:

set day=%date:~0,2%
set mth=%DATE:~3,2%
set yr=%DATE:~6,4%

Windows XP equivalent

Code:

set day=%date:~4,2%
set mth=%DATE:~7,2%
set yr=%DATE:~10,4%

The changes involve adding 4 to each of the pointers in order to jump over the unwanted part of the date in XP. There should be a way to incorporate both blocks of the above code into a batch file, and ensure that the correct section is executed dependant on the system the file is run on.

The code in the following link should be able to help. I'll see if I can extract the necessary part and incorporate it into a new version of the batch file.

http://stackoverflow.com/questions/1...-is-running-on

This is why I love Powershell, you can ask for a special date format instead of depending on the system to provide one you need. As well as a lot more power in Powershell.

Code:

$filedate = get-date -format "yyyy_MM_dd-HH*mm*ss"
// 2011_06_03-08*42*42

Here you go.

Code:

@ECHO OFF
ECHO TIME IS %TIME%
ECHO DATE IS %DATE%
set hour=%time:~0,2%
set mn=%TIME:~3,2%
set sc=%TIME:~6,2%
set msec=%TIME:~9,2%
if %hour% equ 0: set hour=00
for /f "tokens=2 delims=[]" %%G in ('ver') Do (set _version=%%G)
for /f "tokens=2,3,4 delims=. " %%G in ('echo %_version%') Do (set _major=%%G& set _minor=%%H& set _build=%%I)
if "%_major%"=="5" goto sub5
if "%_major%"=="6" goto sub6
goto error
:sub5
set day=%date:~4,2%
set mth=%DATE:~7,2%
set yr=%DATE:~10,4%
goto finish
:sub6
set day=%date:~0,2%
set mth=%DATE:~3,2%
set yr=%DATE:~6,4%
goto finish
:error
echo "unsupported OS."
echo.
pause
pause
exit
:finish
set datefolder=%day%_%mth%_%yr%-%hour%*%mn%*%sc%
echo datefolder is %datefolder%
echo.
pause
pause

Ok. Try this. It modifies the hour parameter so that it is always 2 characters long.

Code:

@ECHO OFF
ECHO TIME IS %TIME%
ECHO DATE IS %DATE%
set hour=%time:~0,2%
set mn=%TIME:~3,2%
set sc=%TIME:~6,2%
set msec=%TIME:~9,2%
for /f "tokens=2 delims=[]" %%G in ('ver') Do (set _version=%%G)
for /f "tokens=2,3,4 delims=. " %%G in ('echo %_version%') Do (set _major=%%G& set _minor=%%H& set _build=%%I)
if "%_major%"=="5" goto sub5
if "%_major%"=="6" goto sub6
goto error
:sub5
set day=%date:~4,2%
set mth=%DATE:~7,2%
set yr=%DATE:~10,4%
goto finish
:sub6
set day=%date:~0,2%
set mth=%DATE:~3,2%
set yr=%DATE:~6,4%
goto finish
:error
echo "unsupported OS."
echo.
pause
pause
exit
:finish
if %hour% geq 10 goto finish1
set hour=0%hour:~1,2%
:finish1
set datefolder=%day%_%mth%_%yr%-%hour%*%mn%*%sc%
echo datefolder is %datefolder%
echo.
pause
pause

This means that if datefolder was 03_06_2011- 6*30*30 it will now be 03_06_2011-06*30*30. In other words, if the hours value is between 0 and 9, an additional leading 0 will be appended.

You're welcome. I'll optimise the code and post back.

Optimised code (including error trapping).

Code:

@ECHO OFF
set hour=%time:~0,2%
if %hour% lss 10 set hour=0%hour:~1,2%
for /f "tokens=2 delims=[]" %%G in ('ver') Do (set _version=%%G)
for /f "tokens=2,3,4 delims=. " %%G in ('echo %_version%') Do (set _major=%%G& set _minor=%%H& set _build=%%I)
if %_major% lss 5 goto error
if %_major% gtr 6 goto error
if "%_major%"=="5" set datefolder=%date:~4,2%_%date:~7,2%_%date:~10,4%-%hour%*%time:~3,2%*%time:~6,2%
if "%_major%"=="6" set datefolder=%date:~0,2%_%date:~3,2%_%date:~6,4%-%hour%*%time:~3,2%*%time:~6,2%
goto finish
:error
echo "Unsupported OS."
echo.
pause
exit
:finish
mkdir "\\path\%datefolder%\"
7z a \\path\%folder%_machinename.zip \\path -xr!_backup -xr!Archive -ssw

The results of the non-optimized code:
datefolder is Sa_ 0_/04/-08*31*37

EDIT: i just changed the date format in the Regonal setting, which fixed the output of the non-optimized code. I will try some more.......

The optimized also seems to have the same issue. It creates nested directory's with strange names.
I wonder if this is just not doable with windows 7 without powershell. If so, that's really a bummer cause the powershell scripts are much more complicated that what I had and what you've written. I will try your script after 10am to see if it works then.