Help debugging simple .bat that worked on XP

[Dwarf]

You're welcome.

I did test the code thoroughly prior to posting it (substituting another variable for the date so that I could check the code operation).

 

[Dwarf]

As a matter of interest, you can modify the above code so that it matches the date format on your system. All you need to do is to make changes to the relevant section(s) in the code I provided. The lines to amend are shown below, with the relevant parts in RED. These are the pointers to the first character in the relevant part of the date string.

if "%_major%"=="5" set datefolder=%date:~[COLOR=Red]4[/COLOR],[COLOR=Blue]2[/COLOR]%_%date:~[COLOR=Red]7[/COLOR],[COLOR=Blue]2[/COLOR]%_%date:~[COLOR=Red]10[/COLOR],[COLOR=Blue]4[/COLOR]%-%hour%*%time:~3,2%*%time:~6,2%
if "%_major%"=="6" set datefolder=%date:~[COLOR=Red]0[/COLOR],[COLOR=Blue]2[/COLOR]%_%date:~[COLOR=Red]3[/COLOR],[COLOR=Blue]2[/COLOR]%_%date:~[COLOR=Red]6[/COLOR],[COLOR=Blue]4[/COLOR]%-%hour%*%time:~3,2%*%time:~6,2%

If you want to change the order of the date component,e.g. so that the year comes first instead of last, you need to change the order of the items in BLUE. Don't forget to change the appropriate RED item as well (they form a pair).

 

[SIW2]

Well done for putting the effort in Dwarf.

I would have done this - but they both work fine.

for /f "tokens=3" %%A in ('reg query "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion" /v CurrentVersion') do set osv=%%A
set nt=%osv:~0,1%