Using mkdir in a batch file to create a directory i Program Files(x86

[RBCC]

I am trying to get this batch file to work





MKDIR C:\Program Files(x86)\NCH Software\NCH Software\Components
MKDIR C:\Program Files(x86)\NCH Software\NCH Software\Photostage
MKDIR C:\Program Files(x86)\NCH Software\NCH Software\Disketch
MKDIR C:\Program Files(x86)\NCH Software\NCH Software\PhotoPad



but all's I get is this:

subdirectory or file C:\Program already exists.
Error occurred while processing: C:\Program.
A subdirectory or file Files(x86)\NCH already exists.
Error occurred while processing: Files(x86)\NCH.
A subdirectory or file Software\NCH already exists.
Error occurred while processing: Software\NCH.
A subdirectory or file C:\Program already exists.
Error occurred while processing: C:\Program.



how do I rewrite program files(x86) to make this work? John

 

[file3456]

It's telling you right there the folders from the program you installed from NCH already exists. Can you confirm?

I use NCH's Wavepad myself, but never had tro use a batch file. Why are you wanting to make a batch file?

 

[iko22]

Not that I understand why you need a batch file, use MKDIR with a "-p" switch placed in your batch file:
MKDIR -p C:\Program Files(x86)\NCH Software\NCH Software\Components
MKDIR -p C:\Program Files(x86)\NCH Software\NCH Software\Photostage
MKDIR -p C:\Program Files(x86)\NCH Software\NCH Software\Disketch
MKDIR -p C:\Program Files(x86)\NCH Software\NCH Software\PhotoPad

 

[Megahertz07]

The issue is there are names bigger then 8 characters. You have to use path between "
Ex.:
MKDIR C:\Program Files(x86)\NCH Software\NCH Software\Components

replace with

MKDIR "C:\Program Files(x86)\NCH Software\NCH Software\Components"

 

[SIW2]

MD "%programfiles(x86)%\NCH Software\NCH Software\Components"

 

[Alejandro85]

When you have a path with spaces or other special characters inside, you have to enclose it in double quotes. Program files is a common source of problems because of this, often resulting in errors saying "c:\program" missing or similar, just like in your post.

 

[Snick]

RBCC

This what I use to check for CBS folder on desktop, if it exists, delete it, make new folder.

if exist %UserProfile%\Desktop\CBS (RD /s /q %UserProfile%\Desktop\CBS)
MD %UserProfile%\Desktop\CBS

/s Deletes a directory tree (the specified directory and all its subdirectories, including all files).
/q Specifies quiet mode. Does not prompt for confirmation when deleting a directory tree. The /q parameter works only if /s is also specified.

Good site for scripts and CMD
SS64.com

 

[Alejandro85]

if exist %UserProfile%\Desktop\CBS (RD /s /q %UserProfile%\Desktop\CBS)
MD %UserProfile%\Desktop\CBS

This has the very same bug as the OP's code. If the path has any space in it, it'll break with a strange error message about a file not being found, which can happen if the %UserProfile% environment variable has spaces (with a user name with spaces, rare but definitely possible). Like the OP, fix it by enclosing all paths in double quotes.

 

[Snick]

Alejandro85

Thank you for the explanation.

I've been using that for years, never, ever had a problem.

However, I will change my code, being that it doesn't break anything.

Question: Why would someone place a space in the path?
Bad coding too?

 

[Megahertz07]

Alejandro85

Thank you for the explanation.

I've been using that for years, never, ever had a problem.

However, I will change my code, being that it doesn't break anything.

Question: Why would someone place a space in the path?
Bad coding too?

Snick
This comes from DOS era and 8x3 character limit. Most CMD are from that era.
You going to find a lot of space characters on windows path
C:\Program Files
C:\Windows\Downloaded Program Files
C:\Windows\Offline Web Pages

 

[Alejandro85]

Alejandro85

Thank you for the explanation.

I've been using that for years, never, ever had a problem.

However, I will change my code, being that it doesn't break anything.

Question: Why would someone place a space in the path?
Bad coding too?

File names with spaces are common place since they've been allowed. Windows itself contains quite a few of them built-in as Megahertz07 said. User documents names with spaces are even more common, and also some other programs use this. The mere fact that Windows allows them means that we must account for their possible presence.
I personally don't think it's a bad practice to use spaces, but many programs forget about them and such kind of bugs occur, unfortunately frequently.

Many programs simply work because they never happen to come by one path with spaces, but are otherwise incapable of handling them. It's not uncommon that some bugs remain undetected for a long time. Both Windows and Linux had bugs hidden for nearly 20 years, the heartbleed vulnerability remained for 2 years, spectre and its relatives were with us since the early Pentium days . My own code most likely has some bugs that nobody noticed and some day will bite someone.
Really, it's common to have such mistakes, and it's a good thing to spot them and fix if it's that easy.

 

[Snick]

Megahertz07
Alejandro85