reading file in windows batch

[aliyesami]

i have a file b.txt with entries like :

explorer.exe pid: 3136 type: File A24: D:\ftproot\logs\tagswap
notepad.exe pid: 7732 type: File 18: D:\ftproot\logs\tagswap


I want to read each record and extract pid and kill it.
The following is only giving me only one record .

for /f "tokens=4 delims= " %%G in (c:\temp\b.txt) do (
SET KILLPIDSTR=%%G
SET KILLPIDSUBSTR=%KILLPIDSTR:~24,5%
echo %KILLPIDSUBSTR%
)

 

[JDobbsy1987]

Hi,

Does this help

SETLOCAL ENABLEDELAYEDEXPANSION

for /f %%G in (c:\temp\b.txt) do (
SET KILLPIDSTR=%%G
SET KILLPIDSUBSTR=%KILLPIDSTR:~24,5%
echo %KILLPIDSUBSTR%
)

Pause

This is what i get when running the above code, as you can see it returns the name of the programs i expect (i did it against calc.exe and notepad.exe):



Part of the problem you have is you are setting a variable and then setting another variable based on the 1st one within the same command, when you do this all variables are set at the same time so technically when you try to do the 2nd SET command its blank as the first one isn't set if that makes sense?

SETLOCAL ENABLEDELAYEDEXPANSION fixes that issue

Regards,
Jamie

 

[aliyesami]

i put your command in but i still dont see the pids assigned to the variable:


C:\TEMP>for /F %G in (c:\temp\b.txt) do (
SET KILLPIDSTR=%G
SET KILLPIDSUBSTR=~24,5
echo
)
C:\TEMP>(
SET KILLPIDSTR=explorer.exe
SET KILLPIDSUBSTR=~24,5
echo
)
ECHO is on.
C:\TEMP>(
SET KILLPIDSTR=notepad.exe
SET KILLPIDSUBSTR=~24,5
echo
)
ECHO is on.
C:\TEMP>

 

[JDobbsy1987]

Sorry, i see what you mean... i can see you are stripping the output in the 2nd SET command, what do you expect to be echo'ed there?

Regards,
Jamie

 

[aliyesami]

i want the pids to be assigned to variable so
KILLPIDSUBSTR=3136
KILLPIDSUBSTR=7732

thanks

 

[JDobbsy1987]

Does this do the trick?

SETLOCAL ENABLEDELAYEDEXPANSION

for /f "tokens=3 delims= " %%G in (b.txt) do (
	SET KILLPIDSTR=%%G
	echo !KILLPIDSTR!
)

pause

Regards,
Jamie